feat: relative timestamps #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashitakah
approved these changes
Oct 17, 2024
xorsal
approved these changes
Oct 17, 2024
Comment on lines
-60
to
-65
| // Revert if the request is finalized before the response deadline | ||
| vm.expectRevert(IBondedResponseModule.BondedResponseModule_TooEarlyToFinalize.selector); | ||
| _arbitrateDispute(_disputeId, IOracle.DisputeStatus.Won); | ||
|
|
||
| // Pass the response deadline | ||
| vm.roll(block.number + responseDeadline); |
There was a problem hiding this comment.
This could still be tested in case that disputeDeadline were less than what's left of responseDeadline at that moment.
Comment on lines
151
to
+152
| // Pass the dispute window | ||
| vm.roll(block.number + responseDisputeWindow - responseDeadline); | ||
| vm.warp(oracle.disputeCreatedAt(_disputeId) + disputeDeadline + 1); |
There was a problem hiding this comment.
Pass the dispute window or pass the dispute deadline?
Also, bear in mind whether they should be computed from the response creation timestamp or the dispute creation timestamp.
Comment on lines
144
to
+145
| // Pass the response deadline | ||
| vm.roll(block.number + responseDeadline); | ||
| vm.warp(oracle.responseCreatedAt(_responseId) + responseDeadline); |
There was a problem hiding this comment.
// Pass the response deadline, but not the dispute deadline
Also, shouldn't it add the responseDeadline to requestCreatedAt?
Comment on lines
52
to
+53
| // Do not pass the dispute deadline | ||
| vm.warp(disputeDeadline); | ||
| vm.warp(_responseCreation + disputeDisputeWindow - 1); |
There was a problem hiding this comment.
Do not pass the dispute deadline or do not pass the dispute window?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-215