fix: thawing tokens #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJabberwock
requested changes
Oct 11, 2024
Comment on lines
35
to
39
| string internal _chainId2; | ||
| uint256 internal _currentEpoch; | ||
| uint256 internal _blockNumber; | ||
|
|
||
| uint96 public currentNonce; |
There was a problem hiding this comment.
I purposely made all variables within IntegrationBase internal so they could be easily differentiated from the public ones inherited from Deploy (which account for all its variables).
Comment on lines
441
to
443
| uint256 _availableTokens = | ||
| _provisionData.tokens > _provisionData.tokensThawing ? _provisionData.tokens - _provisionData.tokensThawing : 0; | ||
| if (_amount > _availableTokens) revert HorizonAccountingExtension_InsufficientTokens(); |
There was a problem hiding this comment.
Hmm, I can't come up with a reason why tokensThawing would ever be greater than tokens, other than rounding issues.
ashitakah
requested changes
Oct 14, 2024
| @@ -49,6 +49,18 @@ contract IntegrationBondEscalation is IntegrationBase { | |||
| // Do not pass the dispute deadline nor the tying buffer | |||
| vm.warp(disputeDeadline); | |||
There was a problem hiding this comment.
I cant find the inssuficientBondedTokens error in the test
0xJabberwock
previously approved these changes
Oct 15, 2024
Base automatically changed from
test/horizon-accounting-extension-integration
to
dev
October 16, 2024 14:07
ashitakah
previously approved these changes
Oct 17, 2024
0xJabberwock
previously approved these changes
Oct 17, 2024
ashitakah
approved these changes
Oct 17, 2024
0xJabberwock
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Linear
Closes GRT-210