test: add cli test to validate multiple manifest generation paths result in comparable output #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btlghrants
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1642 +/- ##
=======================================
Coverage 79.52% 79.52%
=======================================
Files 48 48
Lines 2090 2090
Branches 460 460
=======================================
Hits 1662 1662
- Misses 398 426 +28
+ Partials 30 2 -28 |
samayer12
reviewed
Jan 14, 2025
samayer12
reviewed
Jan 14, 2025
samayer12
requested changes
Jan 14, 2025
btlghrants
force-pushed
the
1640_helm_templates_correspond
branch
from
95257aa to
07a02c9
Compare
Co-authored-by: Sam Mayer <[email protected]>
5 tasks
## Description This PR provides a fix to feedback on #1642 ## Related Issue Relates to #1640 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed
samayer12
approved these changes
Jan 15, 2025
tamirazrab
pushed a commit
to tamirazrab/pepr
that referenced
this pull request
Jan 17, 2025
…ult in comparable output (defenseunicorns#1642) ## Description Adds a new `npm run test:int` (int == "integration") script to invoke a new style of test -- integration tests -- where "integration" means something like "wider in scope than unit tests" but "not requiring a full K8s cluster" (general idea is to have a nice place for non-k8s-required tests to land (e.g. client-side `pepr` CLI commands, like init / build). ## Related Issue Fixes defenseunicorns#1654 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Sam Mayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
npm run test:int(int == "integration") script to invoke a new style of test -- integration tests -- where "integration" means something like "wider in scope than unit tests" but "not requiring a full K8s cluster" (general idea is to have a nice place for non-k8s-required tests to land (e.g. client-sidepeprCLI commands, like init / build).Related Issue
Fixes #1654
Type of change
Checklist before merging