Skip to content

Commit

Permalink
Handle diffrent aiohttp versions
Browse files Browse the repository at this point in the history
  • Loading branch information
@akonarski-ds
akonarski-ds committed Oct 3, 2024
1 parent 53edf48 commit 21280ae
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/ragbits-document-search/tests/unit/test_gcs_source.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ async def test_gcs_source_fetch():
assert path == TEST_FILE_PATH

source = GCSSource(bucket="", object_name="not_found_file.py")
with pytest.raises(aiohttp.ClientResponseError):
with pytest.raises(aiohttp.ClientResponseError, aiohttp.ClientConnectionError):

Check failure on line 21 in packages/ragbits-document-search/tests/unit/test_gcs_source.py

View workflow job for this annotation

GitHub Actions / JUnit Test Report

test_gcs_source.test_gcs_source_fetch 

Failed: DID NOT RAISE <class 'aiohttp.client_exceptions.ClientResponseError'>
Raw output 
async def test_gcs_source_fetch():
        source = GCSSource(bucket="", object_name="test_gcs_source.py")
    
        path = await source.fetch()
        assert path == TEST_FILE_PATH
    
        source = GCSSource(bucket="", object_name="not_found_file.py")
>       with pytest.raises(aiohttp.ClientResponseError, aiohttp.ClientConnectionError):
E       Failed: DID NOT RAISE <class 'aiohttp.client_exceptions.ClientResponseError'>

packages/ragbits-document-search/tests/unit/test_gcs_source.py:21: Failed
await source.fetch()

0 comments on commit 21280ae

Please sign in to comment.