Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change namespace to DeepSeekPhp #15

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

hishamco
Copy link
Contributor

According to https://www.deepseek.com/ & https://en.wikipedia.org/wiki/DeepSeek we should use DeepSeek instead of Deepseek

Much better to use DeepSeek as namespace instead of DeepseekPhp

@omaralalwi
Copy link
Member

omaralalwi commented Jan 28, 2025

@hishamco
please write clear changes in changelos file https://github.com/deepseek-php/deepseek-php-client/blob/master/CHANGELOG.md

these changes should released in new version , new version will be 2.0.0

@hishamco
Copy link
Contributor Author

if DeepSeek as a namespace makes sense, I will write a change log. BTW upcoming version shouldn't necessarily to be 2.0.0 unless there are a major breaking changes

@omaralalwi omaralalwi merged commit 29694f0 into deepseek-php:master Jan 31, 2025
@hishamco hishamco deleted the namespace branch January 31, 2025 20:33
@hishamco
Copy link
Contributor Author

It seems you didn't check my last comment to use DeepSeek instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants