Skip to content

Commit

Permalink
Bluetooth: btintel: Fix the sfi name for BlazarU
Browse files Browse the repository at this point in the history
Use INTEL_HW_VARIANT() instead of CNVi Id to decide to load Intermediate
Loader (IML) image. Fix the driver loading incorrect firmware for
BlazarU product.

dmesg:
.....
[146.111834] Bluetooth: hci0: Minimum firmware build 1 week 10 2014
[146.111839] Bluetooth: hci0: Bootloader timestamp 2022.18 buildtype 1 build 16362
[146.111848] Bluetooth: hci0: No support for _PRR ACPI method
[146.112204] Bluetooth: hci0: Failed to load Intel firmware file intel/ibt-0291-0291-iml.sfi (-2)

Fixes: 164c62f958f8 ("Bluetooth: btintel: Add firmware ID to firmware name")
Reported-by: Tsigan, Vladislav <[email protected]>
Signed-off-by: Kiran K <[email protected]>
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
  • Loading branch information
kirankrishnappa-intel authored and Avenger-285714 committed Jan 13, 2025
1 parent 4c4697c commit 8b7763e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/bluetooth/btintel.c
Original file line number Diff line number Diff line change
Expand Up @@ -2206,7 +2206,7 @@ static void btintel_get_fw_name_tlv(const struct intel_version_tlv *ver,
/* Only Blazar product supports downloading of intermediate loader
* image
*/
if ((ver->cnvi_top & 0xfff) >= BTINTEL_CNVI_BLAZARI) {
if (INTEL_HW_VARIANT(ver->cnvi_bt) >= 0x1e) {
u8 zero[BTINTEL_FWID_MAXLEN];

if (ver->img_type == BTINTEL_IMG_BOOTLOADER) {
Expand Down Expand Up @@ -2298,7 +2298,7 @@ static int btintel_prepare_fw_download_tlv(struct hci_dev *hdev,
* firmware image which doesn't exist. Lets compare the version
* of IML image
*/
if ((ver->cnvi_top & 0xfff) >= BTINTEL_CNVI_BLAZARI)
if (INTEL_HW_VARIANT(ver->cnvi_bt) >= 0x1e)
btintel_get_iml_tlv(ver, fwname, sizeof(fwname), "sfi");
else
btintel_get_fw_name_tlv(ver, fwname, sizeof(fwname), "sfi");
Expand Down

0 comments on commit 8b7763e

Please sign in to comment.