tatanka: switch to lexi db package and clean up message handling #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is wrapping bbolt with badger? |
JoeGruffins
approved these changes
Jan 20, 2025
| type clientRequestHandler = func(c *client, msg *msgjson.Message) *msgjson.Error | ||
| type clientNotificationHandler = func(c *client, msg *msgjson.Message) | ||
|
|
||
| // handleClientMessage handles incoming message from locally-connected clients. |
There was a problem hiding this comment.
Suggested change
| // handleClientMessage handles incoming message from locally-connected clients. | |
| // handleClientMessage handles incoming messages from locally-connected clients. |
| }, nil | ||
| } | ||
|
|
||
| func (db *DB) Connect(ctx context.Context) (*sync.WaitGroup, error) { | ||
| var wg sync.WaitGroup |
There was a problem hiding this comment.
Could add 1 to wg and do wg.Done() after ctx is done so we are sure pruneOldBonds() is finished when shutting down.
| scoredIdx *lexi.Index | ||
| bonds *lexi.Table | ||
| bonderIdx *lexi.Index | ||
| bondStampIdx *lexi.Index | ||
| } | ||
|
|
||
| func New(dir string, log dex.Logger) (*DB, error) { |
There was a problem hiding this comment.
I think we should start with a db version, 0, and check that already. We will need to do that at the beginning of New I guess and do upgrades there. Currently it should error if not version 0.
Maybe it is somewhere I'm missing.
martonp
approved these changes
Jan 24, 2025
| } | ||
|
|
||
| if len(allBonds) > 0 { // Probably no way to get here with empty allBonds, but checking anyway. | ||
| if len(liveBonds) > 0 { // Probably no way to get here with empty allBonds, but checking anyway. |
There was a problem hiding this comment.
Suggested change
| if len(liveBonds) > 0 { // Probably no way to get here with empty allBonds, but checking anyway. | |
| if len(liveBonds) > 0 { // Probably no way to get here with empty liveBonds, but checking anyway. |
Comment on lines
+623
to
+630
| if _, found := t.clientHandlers[msg.Route]; found { | ||
| return t.handleClientMessage(cl, msg) | ||
| } | ||
| if _, found := t.tatankaHandlers[msg.Route]; found { | ||
| return t.handleTatankaMessage(cl, msg) | ||
| } | ||
| if handle, found := t.specialHandlers[msg.Route]; found { | ||
| return handle(cl, msg) |
There was a problem hiding this comment.
Name collisions would mess things up.
| copy(k[tanka.PeerIDLength+6:], penaltyID[:]) | ||
| func (d *DB) Reputation(scored tanka.PeerID) (*tanka.Reputation, error) { | ||
| agg := new(tanka.Reputation) | ||
| var s dbScore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.