Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo for documentation site #7

Merged
merged 17 commits into from
Jul 30, 2020
Merged

Monorepo for documentation site #7

merged 17 commits into from
Jul 30, 2020

Conversation

andreslucena
Copy link
Member

Antora is a multi-repository generator for documentation. This is a little overkill for Decidim at the moment.

This is a WIP at the moment. This adds:

Still, there are lots of things missing but is a starter

Copy link

@AbcSxyZ AbcSxyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposing some improvement in the README to facilitate installation.

README.md Outdated
xdg-open index.html
```

### Manually
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I'm proposing some improvements to the Manually installation section:

I had more an approach of avoiding implicit installation, and showing an installation process where only copy/paste could be done to have something working.

Example here is mainly about node. I'm thinking it's better to display a way to install node to avoid extra search for installation. User who know how node work will skip this step or use a package manager or expected configs.

Check out the given README.md : https://github.com/AbcSxyZ/docs-base/blob/readme/README.md
You could just replace the ### Manually section of the README if you think change are interesting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems better, I'll copy it
I'll add also the node installation, but using nvm, as that's better for working with multiple versions of node (it's similar to rbenv on ruby)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to manage ruby versionning, but I would avoid it because it's adding complexity. I think developer should learn about managing software version in other places. Someone who know node will be already carrying about it, but it can be confusing for non node dev.

Copy link

@AbcSxyZ AbcSxyZ Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT:
I'm wrong it look's good, nvm is not adding complexity to the installation

README.md Outdated

## Install locally

### Docker
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I think manual installation should go first, and using specific tech later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that makes sense... I'm just trying to push "docker as the first option" on Decidim because is more consistent and cleaner, but maybe the world is not ready yet 🤔

Copy link

@AbcSxyZ AbcSxyZ Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, it's making installation easier. People who know docker will check it first, but a person who don't know docker will have to learn/install it first before running any docker command. I don't know what do you expect with "docker as the first option", but just making a docker command available will already increase docker usage

Making the user just copy/paste to get something working seems more interesting, it will be shorter to getting started

@andreslucena
Copy link
Member Author

I've just implemented also #6 and also #2 with the repository https://github.com/decidim/documentation-antora-ui/

I'm going to merge to keep working on other PR with the rest of the issues

Thanks @AbcSxyZ for your feedback! Until we have closed #1 this will be available on http://decidim-documentation.netlify.app/ - after it will be https://docs.decidim.org

@andreslucena andreslucena merged commit 7f72815 into master Jul 30, 2020
@andreslucena andreslucena deleted the feature/monorepo branch July 30, 2020 13:23
@andreslucena andreslucena linked an issue Jul 30, 2020 that may be closed by this pull request
@andreslucena andreslucena changed the title [WIP] Monorepo for documentation site Monorepo for documentation site Jul 30, 2020
This was referenced Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Netlify Deploy Preview
2 participants