Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PortableDID refactoring part 1 #6

Merged
merged 1 commit into from
Feb 6, 2024
Merged

PortableDID refactoring part 1 #6

merged 1 commit into from
Feb 6, 2024

Conversation

amika-sq
Copy link
Contributor

@amika-sq amika-sq commented Feb 5, 2024

First part in the changes to DID creation, PortableDID, and BearerDID from here.

This PR addressed the following refactoring areas:

  • BearerDID now contains the following properties:
    • uri - the DID URI represented
    • document - the full DIDDocument for the BearerDID
    • keyManager - the KeyManager where the backing private keys are stored
    • metadata - a grab bag dictionary/map that can store method-specific information
  • BearerDID can now be exported via the export() function, which returns a PortableDID
  • PortableDID can be imported via a DID Method
    • DIDJWK is the only method currently implemented that can import
    • import() takes in an exported PortableDID, and an optional KeyManager to store the private keys into

I will address the following in a follow-up PR:

  • BearerDID needs to expose a getSigner function

@amika-sq amika-sq merged commit f24e37b into main Feb 6, 2024
1 check passed
@amika-sq amika-sq deleted the dids-refactor-part1 branch February 6, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant