Using PortableDid to import did to sign VC, removing kid as default value
#130
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| { | ||
| "description": "PortableDid resolution", | ||
| "vectors": [ | ||
| { | ||
| "description": "Can be successfully parsed in as PortableDid", | ||
| "input": { | ||
| "uri": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
KendallWeihe marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "privateKeys": [ | ||
| { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "d": "txnECNDxFc0gnD303qLJ6VfWJS8DkgpbxVbOkzzp_M4", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| ], | ||
| "document": { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "verificationMethod": [ | ||
| { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY#z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "type": "JsonWebKey2020", | ||
| "controller": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "publicKeyJwk": { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "metadata": { | ||
| "foo": "bar" | ||
| } | ||
| }, | ||
| "errors": false | ||
| }, | ||
| { | ||
| "description": "Bad PortabieDid - missing uri", | ||
| "input": { | ||
| "privateKeys": [ | ||
| { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "d": "txnECNDxFc0gnD303qLJ6VfWJS8DkgpbxVbOkzzp_M4", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| ], | ||
| "document": { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "verificationMethod": [ | ||
| { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY#z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "type": "JsonWebKey2020", | ||
| "controller": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "publicKeyJwk": { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "metadata": { | ||
| "foo": "bar" | ||
| } | ||
| }, | ||
| "errors": true | ||
| }, | ||
| { | ||
| "description": "Bad PortableDid - missing privateKeys", | ||
| "input": { | ||
| "uri": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "document": { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "verificationMethod": [ | ||
| { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY#z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "type": "JsonWebKey2020", | ||
| "controller": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "publicKeyJwk": { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| "metadata": { | ||
| "foo": "bar" | ||
| } | ||
| }, | ||
| "errors": true | ||
| }, | ||
| { | ||
| "description": "Bad PortableDid - missing document", | ||
| "input": { | ||
| "uri": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "privateKeys": [ | ||
| { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "d": "txnECNDxFc0gnD303qLJ6VfWJS8DkgpbxVbOkzzp_M4", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "foo": "bar" | ||
| } | ||
| }, | ||
| "errors": true | ||
| }, | ||
| { | ||
| "description": "Bad PortableDid - missing metadata", | ||
| "input": { | ||
| "uri": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "privateKeys": [ | ||
| { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "d": "txnECNDxFc0gnD303qLJ6VfWJS8DkgpbxVbOkzzp_M4", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| ], | ||
| "document": { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "verificationMethod": [ | ||
| { | ||
| "id": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY#z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "type": "JsonWebKey2020", | ||
| "controller": "did:key:z6MkfUhjsZUJkzioGDULpcqxXFSNs6McMJo31txYnEaqn9dY", | ||
| "publicKeyJwk": { | ||
| "kty": "OKP", | ||
| "crv": "Ed25519", | ||
| "use": "sig", | ||
| "alg": "EdDSA", | ||
| "kid": "c4IOrQdnehPwQZ6SyNLp9J942VCXrxgWw4zUxAHQXQE", | ||
| "x": "DzpSEyU0w1Myn3lA_piHAI6OrFAnZuEsTwMUPCTwMc8" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "errors": true | ||
| } | ||
| ] | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it too much to ask to use a
did:jwkinstead? since we deprecateddid:keyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test vector specifically tests for creating a VC as a jwt with a
did:keyso i'd like to keep it here :)