-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create vector #294
base: main
Are you sure you want to change the base?
Update create vector #294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use types! types are cool and fun and neato
val evidence = vector.input.credential?.get("evidence") as? List<Any> | ||
|
||
val vc = VerifiableCredential.create( | ||
type = vector.input.credential?.get("type") as String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a lot of ?get("...")
here - have you considered having concrete types for these fields inside vector or credential input?
Overview
Updated the way
VerifiableCredential.create()
worksDescription
The input are the fields for the actual input fields of a vc with the VerifiableCredential.create() method.
The output is the comparison of the VcDataModel object to what is expected.
Web5-Spec changes - decentralized-identity/web5-spec#149
Example test vector: