Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add did:web resolver #97

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Add did:web resolver #97

merged 7 commits into from
Mar 5, 2024

Conversation

KendallWeihe
Copy link
Contributor

@KendallWeihe KendallWeihe commented Feb 28, 2024

Closes #93 and #76

This is very barebones, I opened follow-up tickets (the primary being DNS over HTTPS), but this is a good start.

I pulled DecodeID() into its own function for unit testing purposes; open to other ideas!


Opened new issues:

@KendallWeihe
Copy link
Contributor Author

I'm just realizing I didn't heed this advice ... I'll look at other implementations here shortly

@KendallWeihe KendallWeihe marked this pull request as draft February 28, 2024 21:05
@KendallWeihe KendallWeihe marked this pull request as ready for review March 1, 2024 13:24
@KendallWeihe
Copy link
Contributor Author

Alright I reviewed the other implementations, the main thing I need to follow-up here with is DNS over HTTPS. I added a relevant comment here. This is ready for review.

@KendallWeihe
Copy link
Contributor Author

FYI LinkedIn's DID Doc won't resolve because it has a number of mixed-type properties in it. Added support for part of that here #104

@mistermoe mistermoe merged commit 256e911 into main Mar 5, 2024
2 of 3 checks passed
@mistermoe mistermoe deleted the kendallw/didweb-resolve branch March 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

did:web's Create() does not trim trailing /
2 participants