-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bare minimum presentation definition types #134
Conversation
FYI #131 |
pexv2/pd.go
Outdated
ID string `json:"id,omitempty"` | ||
Name string `json:"name,omitempty"` | ||
Purpose string `json:"purpose,omitempty"` | ||
Format string `json:"format,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format is an object no? are you in move fast and break things mode here? if so could you create a ticket to correct in a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on this same note, missing format
in the InputDescriptor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also fields.optional
and constraints.limit_disclosure
I'm guessing all of this was intentionally left out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aye intentionally left out as it's not needed at the moment. Felt this was better than map[string]any
on the tbdex side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KendallWeihe : removed format for now! 9b78e78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few comments on type definitions but lgtm ✅
Co-authored-by: Kendall Weihe <[email protected]>
Changes
Added bare minimum presentation definition types needed for tbdex
Usage
Added
vc.credentialSchema
and respective create optionNote
currently defaults
credentialSchema.type
toJsonSchema
Important
validation using these JSON Schemas will be added in a subsequent PR
Usage