Add web5 spec resolve test vectors for did dht #125
Conversation
mihai-chiorean
requested review from
alecthomas,
KendallWeihe,
mistermoe,
tomdaffurn and
wesbillman
as code owners
|
this is good for now as it is at least consistent with JS; however really we need new vectors from the spec when the first version is stamped. until then we will have some inconsistency...I have an issue for this here decentralized-identity/web5-spec#11 |
the vectors I'm using actually - which were the ones available - seem to be only error scenarios, no happy path, fwiw |
|
|
||
| const dhtSpecVectors string = "../../web5-spec/test-vectors/did_dht/resolve.json" | ||
|
|
||
| type vector struct { |
There was a problem hiding this comment.
we'll need to move some of this to a shared space in the code repo because we'll need a common interface to retrieve the test vector for the given test case, but we could do that in a follow-up when we expand the scope of test vectors in this repo
There was a problem hiding this comment.
agreed. I want to add "create" vectors too. I could make that change there.
Co-authored-by: Kendall Weihe <[email protected]>
Co-authored-by: Kendall Weihe <[email protected]>
Added a git submodule for did dht spec test vectors, similar to what web5-js does,