Small fix to the attestation signature language #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
reviewed
Mar 29, 2022
|
Pushed a few more small changes |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
OR13
approved these changes
Jun 16, 2022
|
There are conflicts |
TallTed
reviewed
Aug 17, 2022
| 2. The object ****MAY**** have a `replies` property, and if present its value ****MUST**** be an array of *Message Result Objects*{#message-results-objects}, which are constructed as follows: | ||
| 1. The object ****MUST**** have a `messageId` property, and its value ****MUST**** be the stringified [Version 1 CID](https://docs.ipfs.io/concepts/content-addressing/#identifier-formats) of the associated message in the [*Request Object*](#request-object) from which it was received. | ||
| 2. The object ****MUST**** have a `status` property, and its value ****MUST**** be an object composed of the following properties: | ||
| - The status object ****MUST**** have a `code` property, and its value ****MUST**** be an integer set to the [HTTP Status Code](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status) appropriate for the status of the response. | ||
| - The status object ****MAY**** have a `message` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. | ||
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. |
There was a problem hiding this comment.
Suggested change
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. | |
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****RECOMMENDED**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. |
TallTed
reviewed
Aug 17, 2022
| @@ -490,12 +490,12 @@ Responses from Interface method invocations are JSON objects that ****MUST**** b | |||
| 1. The object ****MUST**** include an `requestId` property, and its value ****MUST**** be the [[spec:rfc4122]] UUID Version 4 string from the `requestId` property of the [*Request Object*](#request-object) it is in response to. | |||
| 2. The object ****MAY**** have a `status` property if an error is produced from a general request-related issue, and if present its value ****MUST**** be an object composed of the following properties: | |||
| - The status object ****MUST**** have a `code` property, and its value ****MUST**** be an integer set to the [HTTP Status Code](https://developer.mozilla.org/en-US/docs/Web/HTTP/Status) appropriate for the status of the response. | |||
| - The status object ****MAY**** have a `message` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. | |||
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. | |||
There was a problem hiding this comment.
Suggested change
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****recommended**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. | |
| - The status object ****MAY**** have a `text` property, and if present its value ****MUST**** be a string that describes a terse summary of the status. It is ****RECOMMENDED**** that the implementer set the message text to the standard title of the HTTP Status Code, when a title/message has already been defined for that code. |
|
@cwarny are you willing to make these fixes? |
|
Assigning you for now and we can move it off later if you are unavailable. |
|
motion to close this unless there is an intent to fix conflicts in the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a small inconsistency in the spec regarding what needs signing in the attestation field of a message