fix: 🐛 compare only major version to deteremine outdated node (#28)

debitoor · Oct 9, 2024 · e18ed7c · e18ed7c
1 parent bf5627c
commit e18ed7c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/npm-install/action.yml b/npm-install/action.yml
@@ -164,8 +164,8 @@ runs:
       shell: bash
       env:
         NODE_VERSION: ${{ steps.determine-node-npm-version.outputs.node-version }}
-      # bash can only compare integers, use 'bc' to compare versions like 18.20. Also remove '.x' wildcards that we commonly use in version
-      run: echo outdated-node-version=$(echo "${NODE_VERSION//.x/} < 18" | bc) >> $GITHUB_OUTPUT
+      # remove anything after the first dot from NODE_VERSION and then compare it. 'bc' returns 1 if condition is true
+      run: echo outdated-node-version=$(echo "${NODE_VERSION//.*/} < 18" | bc) >> $GITHUB_OUTPUT
 
     - if: always() && fromJSON(steps.determine-old-node-version.outputs.outdated-node-version)
       name: Comment old NodeJs version