DBZ-8036 Added type to Prometheus JMX exporter
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@missingcharacter Thanks for the PR. Could you please create a Jira describing the change and change the commit message to something like |
Otherwise metrics show up as `untyped`
missingcharacter
changed the title
type to Prometheus JMX exportertype to Prometheus JMX exporter
|
@jpechane I created https://issues.redhat.com/browse/DBZ-8036 for this Pull Request |
|
@missingcharacter LGTM, applied, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise metrics show up as
untypedAlso added
kafka.producermetrics since this is not going to be used with akafka.connectcontainer