Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBZ-8380 Migrate DB2 testsuite to async engine #163

Merged
merged 1 commit into from
Nov 7, 2024
Merged

DBZ-8380 Migrate DB2 testsuite to async engine #163

merged 1 commit into from
Nov 7, 2024

Conversation

vjuranek
Copy link
Member

@vjuranek vjuranek commented Nov 5, 2024

@vjuranek vjuranek marked this pull request as draft November 5, 2024 11:48
@vjuranek
Copy link
Member Author

vjuranek commented Nov 5, 2024

I think these two (or batter to say IncrementalSnapshotIT) fails randomly quite often:

Error:  Failures: 
Error:    IncrementalSnapshotIT>AbstractIncrementalSnapshotTest.snapshotWithAdditionalConditionWithSurrogateKey:1036->AbstractConnectorTest.assertNoRecordsToConsume:1026 expected:<[tru]e> but was:<[fals]e>
Error:    IncrementalSnapshotIT>AbstractIncrementalSnapshotTest.snapshotWithNewAdditionalConditionsField:942->AbstractConnectorTest.assertNoRecordsToConsume:1026 expected:<[tru]e> but was:<[fals]e>
[INFO] 
Error:  Tests run: 83, Failures: 2, Errors: 0, Skipped: 3

@jpechane
Copy link
Contributor

jpechane commented Nov 6, 2024

I se them failing locally now too

@vjuranek
Copy link
Member Author

vjuranek commented Nov 6, 2024

ok, I'll take a look (on my machine it's passing, but I haven't run it many times)

@vjuranek vjuranek marked this pull request as ready for review November 7, 2024 17:20
@vjuranek
Copy link
Member Author

vjuranek commented Nov 7, 2024

Everything passing now, thus merging.

@vjuranek vjuranek merged commit 37d040c into debezium:main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vjuranek @jpechane