Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdpmc tests using libperf #23

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

Nakamura-Shunsuke
Copy link

I will add rdpmc tests using libperf since libperf now supports rdpmc.
These tests are based on perf_event_tests/tests/rdpmc, which assumes that libperf is installed in the /usr/local/lib/ directory.

install command :

git clone https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
cd linux
make -C tools/lib/perf/ DESTDIR=/usr/local/lib/libperf/ install

@Nakamura-Shunsuke
Copy link
Author

@deater ,Is there any missing information to merge the pull requests?
I would appreciate it if you could comment on it.

@Nakamura-Shunsuke
Copy link
Author

@deater , Do you have any comments?
If there is no problem, Would you please merge it if there is no problem?

@robherring
Copy link
Contributor

While I like the idea, I don't think duplicating the tests is a good idea.

@Nakamura-Shunsuke
Copy link
Author

@robherring , Thank you for your comment.

While I like the idea, I don't think duplicating the tests is a good idea.

Do you mean that I should add tests using libperf to the existing source code in tests/rdpmc instead of creating a new tests/rdpmc_libperf?
Or does it mean that adding the same test case is not desirable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants