Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add DDEV v1.24 and latest/nightly to build matrix #16

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

ochorocho
Copy link
Collaborator

@ochorocho ochorocho commented Dec 15, 2024

Add DDEV 1.24 and latest/nightly to the list of versions to built docker images for.

@ochorocho ochorocho self-assigned this Dec 16, 2024
@ochorocho ochorocho requested a review from rfay December 16, 2024 09:18
@rfay
Copy link
Member

rfay commented Dec 16, 2024

Looks great to me, thanks so much for maintaining this! Do you think there would be value in adding DDEV HEAD in there as well? The great thing we get out of testing with HEAD in the add-ons is an early warning system if HEAD breaks some add-on.

@ochorocho
Copy link
Collaborator Author

@rfay how to get the binary for DDEV HEAD or do i have to build it myself?

Any other recommondations before i start? :-)

Currently, just downloading the file from GitHub:
https://github.com/ddev/ddev-gitlab-ci/blob/main/ddev-install.sh#L23

@rfay
Copy link
Member

rfay commented Dec 16, 2024

DDEV HEAD is easy to get, but it's slightly different approach, https://ddev.readthedocs.io/en/stable/developers/building-contributing/#testing-latest-commits-on-head

Not trying to get in your way here. Sure appreciate the maintenance and leadership on this!

@ochorocho ochorocho force-pushed the task/add-ddev-1.24 branch 4 times, most recently from 3153469 to fb29d68 Compare December 16, 2024 22:15
@ochorocho ochorocho changed the title [TASK] Add DDEV v1.24 to build matrix [TASK] Add DDEV v1.24 and latest/nightly to build matrix Dec 16, 2024
@ochorocho
Copy link
Collaborator Author

@rfay can you please have a quick look?
I've added DDEV HEAD as latest tag.

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure looks good to me... especially if it works :)

@ochorocho ochorocho merged commit 8e1b747 into main Dec 17, 2024
8 checks passed
@ochorocho
Copy link
Collaborator Author

@rfay FYI, images are created once a week on Monday at 1:00am.
In case you think we should build it more frequently just let me know.

@rfay
Copy link
Member

rfay commented Dec 17, 2024

I just appreciate you doing it and noting if there's ever a problem. It also will likely be appreciated by some project that needs a feature in HEAD that's not in a release yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants