-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TASK] Add DDEV v1.24 and latest/nightly to build matrix #16
Conversation
Looks great to me, thanks so much for maintaining this! Do you think there would be value in adding DDEV HEAD in there as well? The great thing we get out of testing with HEAD in the add-ons is an early warning system if HEAD breaks some add-on. |
@rfay how to get the binary for DDEV HEAD or do i have to build it myself? Any other recommondations before i start? :-) Currently, just downloading the file from GitHub: |
DDEV HEAD is easy to get, but it's slightly different approach, https://ddev.readthedocs.io/en/stable/developers/building-contributing/#testing-latest-commits-on-head Not trying to get in your way here. Sure appreciate the maintenance and leadership on this! |
3153469
to
fb29d68
Compare
fb29d68
to
3e0b9b1
Compare
@rfay can you please have a quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure looks good to me... especially if it works :)
@rfay FYI, images are created once a week on Monday at 1:00am. |
I just appreciate you doing it and noting if there's ever a problem. It also will likely be appreciated by some project that needs a feature in HEAD that's not in a release yet. |
Add DDEV 1.24 and latest/nightly to the list of versions to built docker images for.