Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added almost full print support #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bat-ventzi
Copy link

added:

  • printOptions;
  • pageSetup;
  • pageMargins;

missing:

  • headers and footers;

@bat-ventzi bat-ventzi mentioned this pull request Jul 29, 2015
root added 2 commits July 29, 2015 14:56
 1. xlsx file is created with LibreOffice Calc v4.2.4.2;
 2. the file is edited with QtXlsxWriter;
 3. MSO 2010 tries to open the file and says there is an error;
 - printOptions;
 - pageSetup;
 - pageMargins;

missing:
 - headers and footers;
@VSRonin
Copy link

VSRonin commented Apr 19, 2016

As the author is not active any more, please submit your pull request to https://github.com/VSRonin/QtXlsxWriter I'll take care of maintaining code until the author is back

rue-ryuzaki added a commit to rue-ryuzaki/QtXlsxWriter that referenced this pull request Nov 29, 2017
@dbcb
Copy link

dbcb commented Jun 11, 2018

Hi Guys, first of all thanks for creating and maintaining this package.
@VSRonin: The changes from bat-ventzi seems to me very important.
Is there a reason, why it is not pulles to your repository?
Thanks

@VSRonin
Copy link

VSRonin commented Jun 13, 2018

@bat-ventzi never opened a pull request on my repository and just stealing his/her contribution from here would be at least unethical.
Happy to review the code and work toward a merge if a pull request is opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants