Workflow cancel , restart, resume as admin API #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftp
reviewed
Jan 29, 2025
tests/test_admin_server.py
Outdated
| else: | ||
| new_wfUuid = output[0].workflowUUID | ||
|
|
||
| print(new_wfUuid) |
kraftp
reviewed
Jan 29, 2025
| @@ -767,13 +777,30 @@ def execute_workflow_id(cls, workflow_id: str) -> WorkflowHandle[Any]: | |||
| """Execute a workflow by ID (for recovery).""" | |||
| return execute_workflow_by_id(_get_dbos_instance(), workflow_id) | |||
|
|
|||
| @classmethod | |||
| def restart_workflow(cls, workflow_id: str) -> None: | |||
There was a problem hiding this comment.
Are these new methods part of the public API?
There was a problem hiding this comment.
They are called from the admin server. Not sure what you mean by public api
kraftp
reviewed
Jan 29, 2025
dbos/cli.py
Outdated
| print(f"Failed to resume workflow {uuid}. Status code: {response.status_code}") | ||
|
|
||
|
|
||
| @workflow.command(help="Restart a workflow that has been cancelled with a new id") |
There was a problem hiding this comment.
Suggested change
| @workflow.command(help="Restart a workflow that has been cancelled with a new id") | |
| @workflow.command(help="Restart a workflow from the beginning with a new workflow ID") |
maxdml
reviewed
Jan 29, 2025
Comment on lines
+19
to
+21
| # /workflows/:workflow_id/cancel | ||
| # /workflows/:workflow_id/resume | ||
| # /workflows/:workflow_id/restart |
There was a problem hiding this comment.
What are these comments for?
There was a problem hiding this comment.
For other engineers to see what the url looks like
dbos/_admin_server.py
Outdated
| def _handle_restart(self, workflow_id: str) -> None: | ||
| self.dbos.restart_workflow(workflow_id) | ||
| print("Restarting workflow", workflow_id) | ||
| self.send_response(200) |
There was a problem hiding this comment.
Can we return 204? The server doesn't return anything to the client
dbos/_dbos.py
Outdated
|
|
||
| @classmethod | ||
| def resume_workflow(cls, workflow_id: str) -> None: | ||
| """Cancel a workflow by ID.""" |
There was a problem hiding this comment.
Suggested change
| """Cancel a workflow by ID.""" | |
| """Resume a workflow by ID.""" |
dbos/_dbos.py
Outdated
| @@ -231,9 +233,17 @@ def __new__( | |||
| f"DBOS configured multiple times with conflicting information" | |||
| ) | |||
| config = _dbos_global_registry.config | |||
|
|
|||
| print("calling new setting up the global instance") | |||
There was a problem hiding this comment.
Is it possible to call the DBOS logger for all these statements? So they get exported, etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.