return delay files in geo coords if geocoded aoi #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
addresses #403. note that outputs will still be saved in WGS84 |
|
This needs to be more carefully vetted before merging as it may have unintended consequences |
|
I dont think proj input is to be kept. We added proj as output not sure why
we need it as input if we enforce the coordinate to be gdal compatible.
Jeremy thoughts?
…On Wed, Nov 23, 2022 at 11:08 AM BB ***@***.***> wrote:
This needs to be more carefully vetted before merging as it may have
unintended consequences
—
Reply to this email directly, view it on GitHub
<#408 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AESZPSNF5XNIA4ZUDK3WENTWJZTTBANCNFSM6AAAAAASJHRHPQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
jlmaurer
reviewed
Nov 28, 2022
| @@ -72,7 +72,7 @@ def get_heights(args, out, station_file, bounding_box=None): | |||
| elif os.path.exists(args.dem): | |||
| out['dem'] = args['dem'] | |||
| if bounding_box is not None: | |||
| dem_bounds = rio_extents(rio_profile(args.dem)) | |||
There was a problem hiding this comment.
Should we add a try/except here so either will work? Or is it always [0]?
| @@ -118,7 +118,7 @@ def tropo_delay(dt, wetFilename, hydroFilename, args): | |||
|
|
|||
| ########################################################### | |||
| # Load the downloaded model file for CRS information | |||
| wm_proj = rio_profile(f"netcdf:{weather_model_file}:t")["crs"] | |||
There was a problem hiding this comment.
Same thing here as above, and below as well.
| @@ -120,7 +123,13 @@ def rio_profile(fname): | |||
| f"{fname} does not contain geotransform information" | |||
| ) | |||
|
|
|||
| return profile | |||
| elif profile['crs'].to_epsg() != 4326: | |||
| fname_wgs84 = rio_reproject_geocoded(fname) | |||
There was a problem hiding this comment.
Is this the part that wasn't working to correctly reproject the outputs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user passes in a geocoded file for the AOI, the resulting wet/hydro delays will be written in those coords
Note that the
projinput argument is not currently supported and should be removed until it's implemented (which may take some doing)