Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering of arrow keys in TTY-driver #193

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

venomix666
Copy link
Contributor

This PR adds filtering of the arrow keys in the TTY drivers of the Oric, PET and nano6502. The Atari does not need the filtering as the translation is done in the SCREEN driver.

I tried to also add filtering to the BBC Micro, but there is seems like the MOS moves the cursor when pressing the arrow keys and I didn't find a simple way to prevent that.

@venomix666
Copy link
Contributor Author

Same problem with getroms.sh here as for Ivop's latest PR, seems like archive.org is down.

@ivop
Copy link
Contributor

ivop commented Oct 13, 2024

Looks like archive.org got hit by a DDOS and was hacked via a javascript library vulnerability. Usernames and salted passwords were stolen. News is they'll be back in days, not weeks.

@davidgiven
Copy link
Owner

I'll assume this works --- merging. Thanks!

Re the BBC Micro: this is actually a bit more complicated than it looks due to MOS' built in line editor. When doing normal editing, the cursor keys move a secondary cursor; pressing COPY will then copy whatever the secondary cursor is looking at into the buffer. But, when not line editing it would be desirable to make them produce normal keycodes. In order to support that the SCREEN driver would have to have a couple of extra entrypoints for start_line_editing and end_line_editing, but I'm not convinced they're worth adding just for the BBC Micro.

@davidgiven davidgiven merged commit 860b5ef into davidgiven:master Oct 18, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants