zmalloc update #185
Merged
zmalloc update #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversing free list, remove unsafe pointer usage.
|
Closed/reopened to force running CI again (getting ROMs failed the first time). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed I constantly added and subtracted the size of the size field, so including it in its own definition reduces the amount of additions and subtractions. It's now only added at the beginning (added to the requested size).
The "unsafe" pointer usage actually worked on Linux (64-bit) but llvm-mos generates 500 bytes of assembly that does not work for <10 lines of C code that's only a few loads and stores, so for now I removed it. It's not really a big deal, as DS always increases/decreases in steps large enough to not matter anyway.
Binary shrunk ~600 bytes.