-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple2 plus #177
Draft
andreasbaumann
wants to merge
49
commits into
davidgiven:master
Choose a base branch
from
andreasbaumann:apple2_plus
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Apple2 plus #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library for shared code (not working)
…aste code and issues around stopping the disk drive motor
…n_getchar and missing timeout and randomness)
…ong) wrapper for using it in tetris.c (screen.S) handling the carry bit for detecting timeouts in scrntest.asm
…d commenct format (unknown entry name) with echo
This was referenced Sep 17, 2024
…in bios, the standalone driver might be an idea for a Videx 80-column driver..
… printing letter instead of # for pieces
Kroc
reviewed
Jan 6, 2025
@@ -95,9 +102,55 @@ mainloop: | |||
stx cur_y | |||
|
|||
timeout: | |||
\ Show spinnig bar to test non-blocking keyboard read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo "spinnig"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
-DAPPLE2E
and-DAPPLE2PLUS
insrc/arch/apple2e/build.py
andsrc/arch/apple2e/utilsbuild.py
, ugly)Current list of bugs:
The branch might be a little bit too soon to merge, I didn't test it yet after the merge, to be frank. :-)