Allow char literal convertion into unsigned #82
Conversation
required to compile stm32mp1xxx dtb
|
It looks fine, but let's wait for a review. |
|
Thanks. I am happy to merge this, but I'd prefer if we handled common escape characters in character literals first. |
input_buffer.cc
Outdated
| outInt = (unsigned char)'\r'; | ||
| break; | ||
| default: | ||
| // Let any other symbol to resolves to itself. |
There was a problem hiding this comment.
not sure about this. Just think it is better to allow.
There was a problem hiding this comment.
It would be good to handle \, ' and \t here as well. Anything else should probably be an error. In particular, at some point someone might decide that they want to write '\x1234' and we should report that this is not something that we're handling.
This also assumes single-byte characters, but I'm happy with that for now because otherwise we may have to think about endian issues.
input_buffer.cc
Outdated
| outInt = (unsigned char)'\r'; | ||
| break; | ||
| default: | ||
| // Let any other symbol to resolves to itself. |
There was a problem hiding this comment.
It would be good to handle \, ' and \t here as well. Anything else should probably be an error. In particular, at some point someone might decide that they want to write '\x1234' and we should report that this is not something that we're handling.
This also assumes single-byte characters, but I'm happy with that for now because otherwise we may have to think about endian issues.
| break; | ||
| case '\'': | ||
| case '\\': | ||
| break; |
There was a problem hiding this comment.
Minor style nit, but it’s good to put default first so that nothing accidentally falls through into it.
ssilnicki-dev
force-pushed
the
stm32mp1_fix
branch
from
b722b45 to
db2bc48
Compare
|
please squash & merge. I prefer to keep history |
|
Thanks! |
|
Thank you! |
required to compile stm32mp1xxx dtb