Fix handling of unmanaged type parameter constraint #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a method had the 'unmanaged' constraint specified, then the interface generator would output both 'struct' and 'unmanaged' constraints. However, the C# specification explicitly forbids to combine these constraints. The problem is that when the `HasUnmanagedTypeConstraint` property of `ITypeParameterSymbol` is true, then `HasValueTypeConstraint` is also true. To fix the issue the `class` / `struct` / `unmanaged` / `notnull` constraints need to be treated as mutually exclusive, and `unmanaged` needs to be checked before `struct`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a method had the 'unmanaged' constraint specified, then the interface generator would output both 'struct' and 'unmanaged' constraints. However, the C# specification explicitly forbids to combine these constraints.
The problem is that when the
HasUnmanagedTypeConstraintproperty ofITypeParameterSymbolis true, thenHasValueTypeConstraintis also true. To fix the issue theclass/struct/unmanaged/notnullconstraints need to be treated as mutually exclusive, andunmanagedneeds to be checked beforestruct.