Skip to content
This repository has been archived by the owner on Nov 5, 2019. It is now read-only.

Communities #38

Merged
merged 8 commits into from
Jul 15, 2017
Merged

Communities #38

merged 8 commits into from
Jul 15, 2017

Conversation

b5
Copy link
Member

@b5 b5 commented Jul 13, 2017

This PR closes out part 1 of this roadmap item

I'm going to keep improving / refining, but the rough bits are in place for merging anytime.

@b5 b5 requested a review from flyingzumwalt July 13, 2017 01:25
@b5 b5 requested review from dcwalk and titaniumbones July 14, 2017 17:33
@b5
Copy link
Member Author

b5 commented Jul 14, 2017

Ok, so there's a 50/50 chance you'll be able to give this a try locally now 😉
Instructions:

  1. Make sure you have docker and docker-compose.
  2. Clone this repo, cd into the top dir.
  3. git fetch
  4. git checkout communities
  5. docker-compose up. wait a long time, console will settle down.
  6. browser -> localhost:3000/login. username: jeffliu, password: password
  7. see if you can hit "archive" on the "All of the puppies" collection.

There are so. many. bugs. said bugs can & will be fixed. I'd like this to be considered mergeable if someone else can get the above to work.

@b5 b5 requested a review from machawk1 July 14, 2017 17:46
Copy link
Member

@machawk1 machawk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to follow the above procedure with success -- I saw puppies (see attached). On the initial visit, hitting the Archive button within the collection didn't appear to do anything on-screen. It was only when I revisited the page after navigating away did I see the IPFS hashes.

I also tried to ipfs get the individual hashes with the container running but the payload was not readable as an image (and only 66 bytes).

screen shot 2017-07-14 at 4 42 29 pm

@flyingzumwalt
Copy link

same as @machawk1. got it to work. after hitting "archive" I had to reload the page in order to see the ipfs hashes.

FYI: the "archive" link didn't appear at first but I restarted docker and then it appeared. not sure what was wrong. I had previously loaded a different branch of the code, so might be that.

@flyingzumwalt
Copy link

should we merge this and then fix bugs iteratively in separate PRs?

@b5
Copy link
Member Author

b5 commented Jul 15, 2017

I mean, this convo has images of puppies. Isn't this grounds for merging?

@flyingzumwalt
Copy link

I think it's a level up from what's in master. Better to get that in master and then move forward from there. I will merge.

@b5
Copy link
Member Author

b5 commented Jul 15, 2017

but yes, I vote we merge & file lots of issues for existing bugs. I think increased participation in the design/dev process is more important than clean code at this point, and we can rapidly iterate on improvements.

@flyingzumwalt flyingzumwalt merged commit 33f1716 into master Jul 15, 2017
@flyingzumwalt flyingzumwalt deleted the communities branch July 15, 2017 01:00
@machawk1
Copy link
Member

machawk1 commented Jul 15, 2017

@b5 I want to add that I did not see the Archive link on the initial load as well (like @flyingzumwalt). I navigated away, back to the puppies collection then saw the Archive link. I hit the link, navigated away and navigated back, and only THEN saw the hashes. All seemed right on repeated docker-up, the hashes persisted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants