-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Ok, so there's a 50/50 chance you'll be able to give this a try locally now 😉
There are so. many. bugs. said bugs can & will be fixed. I'd like this to be considered mergeable if someone else can get the above to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to follow the above procedure with success -- I saw puppies (see attached). On the initial visit, hitting the Archive button within the collection didn't appear to do anything on-screen. It was only when I revisited the page after navigating away did I see the IPFS hashes.
I also tried to ipfs get the individual hashes with the container running but the payload was not readable as an image (and only 66 bytes).
same as @machawk1. got it to work. after hitting "archive" I had to reload the page in order to see the ipfs hashes. FYI: the "archive" link didn't appear at first but I restarted docker and then it appeared. not sure what was wrong. I had previously loaded a different branch of the code, so might be that. |
should we merge this and then fix bugs iteratively in separate PRs? |
I mean, this convo has images of puppies. Isn't this grounds for merging? |
I think it's a level up from what's in master. Better to get that in master and then move forward from there. I will merge. |
but yes, I vote we merge & file lots of issues for existing bugs. I think increased participation in the design/dev process is more important than clean code at this point, and we can rapidly iterate on improvements. |
@b5 I want to add that I did not see the Archive link on the initial load as well (like @flyingzumwalt). I navigated away, back to the puppies collection then saw the Archive link. I hit the link, navigated away and navigated back, and only THEN saw the hashes. All seemed right on repeated |
This PR closes out part 1 of this roadmap item
I'm going to keep improving / refining, but the rough bits are in place for merging anytime.