Install-DbaMaintenanceSolution - don't drop tables if not readding #9570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Invoke-ManualPester
)Purpose
Reported in #9553 the
CommandLog
table is always dropped whenReplaceExisting
is specified - this is causing issues if the SPs are calling theLogToTable
parameter.Approach
This change provides more control - the tables will only be dropped if the switches that use them are specified. This way if you want to keep the history in the
CommandLog
table but update the SPs you can.I implemented the same logic for the
InstallParallel
parameter - and theQueue*
tables - if the parameter is specified they will be dropped, if not they will remain on the server.Commands to test
This will drop and replace all the SPs but none of the tables.
This will drop and replace the SPs and the
CommandLog
tableThis will drop and create SPs and all tables.