fix sticky button bug #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hancush could you speak to whether we need this code in _position.cc? |
hancush
reviewed
Nov 17, 2021
Comment on lines
39
to
45
| .sticky-top-button { | ||
| @supports (position: sticky) { | ||
| position: sticky; | ||
| top: 55px; | ||
| z-index: $zindex-sticky; | ||
| } | ||
| } |
There was a problem hiding this comment.
The static/bootstrap/* Sass files define a custom Bootstrap build, which the bootstrap-overrides.css file then, as you might guess, overrides. (Docs would be too convenient, but I took and documented a similar approach over in CA FWD: https://github.com/datamade/california-dream-index#compiling-sass-to-css)
So, you only need to define this new custom class in bootstrap-overrides.css.
There was a problem hiding this comment.
Actually, the most appropriate place would probably be custom.css.
fgregg
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes issue #531.
Demo
Notes
The existing
sticky-topCSS was declared in two places:bootstrap-overrides.cssand_position.css. I changed it inbootstrap-overrides.cssand this worked. I wasn't sure about the purpose of_position.cssfile since the existingsticky-topCSS declaration was already set elsewhere, so I added it there just to be safe.Testing
sticky-buttonbranch