Support for volumes in AWS and GCP #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelafa
suggested changes
Jan 16, 2018
| @@ -59,7 +59,6 @@ RUN R --slave --no-restore \ | |||
|
|
|||
| # Entry point | |||
| WORKDIR /home/dataiku | |||
| USER dataiku | |||
There was a problem hiding this comment.
Please try to avoid as much as possible execution of run.sh as root
In theDockerFile permissions are already enforced for the data directory
If it's a cloud provider level permission issue we should consider that enforcing container level related permissions must fix the problem.
You can also fork the DockerFile if you are willing to handle a EBS (or equivalent ) within docker image definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to mount a volume (disk in GCP) to the docker image and installation of app aborts with the following error
The current logic in the wrapper script which is run as entry point to the Dataiku-provided Docker image
https://github.com/dataiku/dataiku-tools/blob/master/dss-docker/run.sh
looks at the provided data directory for a well-known DSS file in order to automatically determine whether it should install a new instance or upgrade an existing one, as a convenience for an easier use.
It should be possible to change that in a production environment to adapt to use a EBS volume or a GCP disk.