Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): move reading env variable inside method #12549

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Feb 4, 2025

In case we try to run this in a kubernetes environment this causes failures

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the smoke_test Contains changes related to smoke tests label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e8a0a...1edef39. Read the comment docs.

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 4, 2025
@@ -27,15 +27,13 @@ def infer_kafka_broker_container() -> str:
return lines[0]


KAFKA_BROKER_CONTAINER: str = str(
Copy link
Collaborator

@david-leifker david-leifker Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should likely be converted to a test fixture. Resolve it once, lazy or not, but then inject it into the tests like we did for the graph_client and auth_session. This way it would not only be resolved when needed but then only by the tests which require it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we make it a test fixture then it will still try to resolve it. That is not needed for the cases where USE_STATIC_SLEEP = true

@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Feb 4, 2025
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 4, 2025
@anshbansal anshbansal merged commit e1ce780 into master Feb 4, 2025
216 of 247 checks passed
@anshbansal anshbansal deleted the ab-2025-feb-04-move-inside-method branch February 4, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge smoke_test Contains changes related to smoke tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants