Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(iceberg): add iceberg user guide #12533

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

docs(iceberg): add iceberg user guide #12533

wants to merge 8 commits into from
+410 −0

Conversation

chakru-r
Copy link
Collaborator

@chakru-r chakru-r commented Feb 3, 2025

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Feb 3, 2025
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Feb 3, 2025
shirshanka
shirshanka reviewed Feb 4, 2025
View reviewed changes
docs/iceberg-catalog.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added pending-submitter-response Issue/request has been reviewed but requires a response from the submitter and removed needs-review Label for PRs that need review from a maintainer. labels Feb 4, 2025
shirshanka
shirshanka reviewed Feb 4, 2025
View reviewed changes
docs/iceberg-catalog.md Outdated Show resolved Hide resolved
shirshanka
shirshanka approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - apart from the small comments.

shirshanka
shirshanka reviewed Feb 4, 2025
View reviewed changes
docs/iceberg-catalog.md Outdated Show resolved Hide resolved
pedro93
pedro93 reviewed Feb 4, 2025
View reviewed changes
docs/iceberg-catalog.md Outdated Show resolved Hide resolved
@datahub-cyborg datahub-cyborg bot added needs-review Label for PRs that need review from a maintainer. and removed pending-submitter-response Issue/request has been reviewed but requires a response from the submitter labels Feb 4, 2025
@chakru-r chakru-r force-pushed the cr-iceberg-userguide branch from 19e26e0 to 05502cf Compare February 4, 2025 14:18
@chakru-r chakru-r force-pushed the cr-iceberg-userguide branch 2 times, most recently from 048e8f9 to a78f63e Compare February 4, 2025 14:57
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

see 213 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7598ca...ae948b1. Read the comment docs.

@chakru-r chakru-r force-pushed the cr-iceberg-userguide branch from a78f63e to 5c4b17e Compare February 4, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedro93 pedro93 pedro93 left review comments

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs needs-review Label for PRs that need review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chakru-r @shirshanka @pedro93