Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New newsletter design #634

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

nicolaskempf57
Copy link
Contributor

Copy link
Contributor

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this new footer version ✨

Things I see that differ between udata-front and front-end:

  • logo twitter
  • Open data h3 size is not similar (due to datagouv components override?)
  • Follow us on social media is not vertically aligned with Subscribe to our newsletter
  • See our next events button is blue or black
  • data.gouv.fr logo size
  • Data catalog does not exist in front-end
  • A product of the Direction Interministérielle du Numérique(DINUM). horizontal alignment differs between the two (maybe due to language picker missing?)
  • Licenses is to be preferred instead of Licences
  • horizontal spacing between Licenses and Terms of use

@nicolaskempf57
Copy link
Contributor Author

  • Data catalog does not exist in front-end

I added a csvDatasetId runtime variable to pass the id, to match the udata-front side

  • A product of the Direction Interministérielle du Numérique(DINUM). horizontal alignment differs between the two (maybe due to language picker missing?)

Indeed, this is the cause of this misalignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nouveau design du bandeau newsletter sur udata-front
2 participants