New homepage #626
Open
New homepage #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maudetes
approved these changes
Jan 10, 2025
| {{ label }} | ||
| <section class="fr-container--fluid"> | ||
| <div class="fr-grid-row fr-grid-row--gutters"> | ||
| <div class="fr-col-12 fr-col-lg-6 fr-pr-md-10w fr-py-4w fr-pt-12w fr-py-md-12w fr-px-md-10w"> |
There was a problem hiding this comment.
I think we should have some padding in responsive mode on this section
There was a problem hiding this comment.
Additionally, I think the different numbers and organizations are a bit spread apart horizontally on my screen
There was a problem hiding this comment.
Don't forget the changelog ;)
| href="{{ url_for('gouvfr.show_page', slug='donnees-energie') }}"> | ||
| <span aria-hidden="true" class="fr-icon-notification-3-line fr-icon--sm fr-mr-1w"></span> | ||
| <span class="fr-text--bold fr-mb-0">{{ _('Right now') }}</span> | ||
| <span class="text-overflow-ellipsis"> : Données relatives aux Énergies</span> |
There was a problem hiding this comment.
Ahaha we'll still need a release to update these for now 😛
| <figcaption class="subtitle subtitle--uppercase text-mention-grey"> | ||
| {{_('datasets')}} | ||
| </figcaption> | ||
| <img |
There was a problem hiding this comment.
This image doesn't seem to work
| </figcaption> | ||
| <img | ||
| class="mw-100" | ||
| srcset="{{theme_static('img/homepage/reuses.png')}}, {{theme_static('img/homepage/[email protected]')}} 2x, {{theme_static('img/homepage/[email protected]')}} 3x" |
There was a problem hiding this comment.
I think the default reuses.png is loaded on my desktop env and not the bigger ones?
| <div class="fr-grid-row fr-grid-row--gutters"> | ||
| <div class="fr-col-12 fr-col-sm-6 fr-col-lg-4 fr-pl-md-5v"> | ||
| <span class="fr-mt-1v fr-icon-search-line" aria-hidden="true"></span> | ||
| <p class="fr-mt-1w fr-mb-1v">{{_('Ease data discoverability')}}</p> |
There was a problem hiding this comment.
Suggested change
| <p class="fr-mt-1w fr-mb-1v">{{_('Ease data discoverability')}}</p> | |
| <p class="fr-mt-1w fr-mb-1v">{{_('Facilitate data discoverability')}}</p> |
| <div class="fr-card__body"> | ||
| <div class="fr-card__content fr-px-2w fr-pt-2w fr-pb-0"> | ||
| <h5 class="fr-card__title subtitle subtitle--uppercase fr-text--sm text-grey-300 fr-m-0"> | ||
| Explorateur de données de valeurs foncières |
There was a problem hiding this comment.
We don't want to translate the product name (same for annuaire)?
| <section> | ||
| <h3 class="fs-xxxl font-800">{{_('Simplify access to public data')}}</h3> | ||
| <p class="fr-mb-3w fs-xxxl line-height-xxxl text-grey-200 font-300">{{_('The opening and circulation of public data strengthen transparency, improve public action, and allow for the creation of new services.')}}</p> | ||
| <p class="fr-mb-4w fs-xxxl line-height-xxxl text-grey-200 font-300">{{_('{site} provides access to this information by organizing its dissemination and use.'.format(site=config.SITE_TITLE))}}</p> |
There was a problem hiding this comment.
Suggested change
| <p class="fr-mb-4w fs-xxxl line-height-xxxl text-grey-200 font-300">{{_('{site} provides access to this information by organizing its dissemination and use.'.format(site=config.SITE_TITLE))}}</p> | |
| <p class="fr-mb-4w fs-xxxl line-height-xxxl text-grey-200 font-300">{{_('{site} makes this information available by organizing its distribution and use.'.format(site=config.SITE_TITLE))}}</p> |
| </div> | ||
| </section> | ||
| <section class="relative z-2 fr-container--fluid"> | ||
| <div class="fr-grid-row fr-grid-row--gutters"> |
There was a problem hiding this comment.
I think the two div should be switched to display the image on the left?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes datagouv/data.gouv.fr#1635