Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for publishers, creators and contributors #528

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

maudetes
Copy link
Contributor

@maudetes maudetes commented Sep 18, 2024

Add these responsible parties on dataset page.

Play around to add a multiselect on credits suggest to filter on these responsible parties.

This is based on opendatateam/udata#3149

DON'T MERGE BEFORE REVERTING THE UPDATE TO THE UDATA.IN FILE

@maudetes maudetes marked this pull request as draft September 18, 2024 13:51
@magopian
Copy link
Contributor

@maudetes updated based on our discussion. I don't know how to fix the CI failing, as it's because it needs #3149 to succeed...

What do you think?

@magopian magopian marked this pull request as ready for review January 16, 2025 14:15
Copy link
Contributor Author

@maudetes maudetes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR update! 🎉

@maudetes
Copy link
Contributor Author

@maudetes updated based on our discussion. I don't know how to fix the CI failing, as it's because it needs #3149 to succeed...

You can temporarily points towards the udata branch in https://github.com/datagouv/udata-front/blob/master/requirements/udata.in to make sure the CI pass as expected.

@magopian magopian force-pushed the feat/add-responsible-party-roles branch 2 times, most recently from fa1aa98 to 98a0a1b Compare January 16, 2025 16:44
@magopian magopian force-pushed the feat/add-responsible-party-roles branch from 98a0a1b to c71abea Compare January 16, 2025 17:14
@@ -1 +1 @@
udata@git+https://github.com/opendatateam/udata.git
udata@git+https://github.com/maudetes/udata.git@feat/add-roles-in-harvest-extras
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to rollback this change

@magopian
Copy link
Contributor

So... I believe this is done now, and we should
1/ merge opendatateam/udata#3149
2/ revert the two last commits from this PR (the temporary udata dependency change meant for the CI)
3/ merge this PR

What do you think @maudetes ?

@nicolaskempf57 nicolaskempf57 linked an issue Jan 20, 2025 that may be closed by this pull request
@@ -37,6 +37,13 @@ export type BaseDataset = Owned & {
zones?: Array<string>;
granularity?: string;
} | null;
contact_points: Array<{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the API is sending :

  • contact_form (can be null)
  • email (can be null)
  • id
  • name
  • role

Also, can you add this type as a separate one and use it in both datasets and dataservices files ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gestion des multi producteurs
3 participants