-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for publishers, creators and contributors #528
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR update! 🎉
You can temporarily points towards the udata branch in https://github.com/datagouv/udata-front/blob/master/requirements/udata.in to make sure the CI pass as expected. |
fa1aa98
to
98a0a1b
Compare
98a0a1b
to
c71abea
Compare
@@ -1 +1 @@ | |||
udata@git+https://github.com/opendatateam/udata.git | |||
udata@git+https://github.com/maudetes/udata.git@feat/add-roles-in-harvest-extras |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to rollback this change
So... I believe this is done now, and we should What do you think @maudetes ? |
@@ -37,6 +37,13 @@ export type BaseDataset = Owned & { | |||
zones?: Array<string>; | |||
granularity?: string; | |||
} | null; | |||
contact_points: Array<{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the API is sending :
- contact_form (can be null)
- email (can be null)
- id
- name
- role
Also, can you add this type as a separate one and use it in both datasets and dataservices files ?
Add these responsible parties on dataset page.
Play around to add a multiselect on credits suggest to filter on these responsible parties.
This is based on opendatateam/udata#3149
DON'T MERGE BEFORE REVERTING THE UPDATE TO THE UDATA.IN FILE