-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account editing cleanup #1983
Account editing cleanup #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in the future we can add type validation on email and ISSN fields.
Currently if you enter incorrect value format there is no error and the values are not saved
I think we have type validation for these on the model, do you mean we need client side validation as well? |
Yes, I was talking about adding the validations on the forms too. |
@alinvetian I've added basic validation for user email and journal issns |
I've added quite complicated model validation and client errors, including on creation, for ISSNs and for all email addresses including those in arrays in the non-user models |
Suggested from #1912
Closes datadryad/dryad-product-roadmap#3881
Blocking datadryad/dryad-product-roadmap#3549