Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account editing cleanup #1983

Merged
merged 15 commits into from
Jan 24, 2025
Merged

Account editing cleanup #1983

merged 15 commits into from
Jan 24, 2025

Conversation

ahamelers
Copy link
Collaborator

@ahamelers ahamelers commented Jan 22, 2025

@ahamelers ahamelers requested a review from alinvetian January 22, 2025 14:30
Copy link
Contributor

@alinvetian alinvetian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in the future we can add type validation on email and ISSN fields.
Currently if you enter incorrect value format there is no error and the values are not saved

@ahamelers
Copy link
Collaborator Author

Maybe in the future we can add type validation on email and ISSN fields. Currently if you enter incorrect value format there is no error and the values are not saved

I think we have type validation for these on the model, do you mean we need client side validation as well?

@alinvetian
Copy link
Contributor

Yes, I was talking about adding the validations on the forms too.
Currently it behaves like in production so we can make this a future story.

@ahamelers
Copy link
Collaborator Author

@alinvetian I've added basic validation for user email and journal issns

@ahamelers
Copy link
Collaborator Author

ahamelers commented Jan 23, 2025

I've added quite complicated model validation and client errors, including on creation, for ISSNs and for all email addresses including those in arrays in the non-user models

@ahamelers ahamelers requested a review from alinvetian January 23, 2025 18:48
app/models/stash_engine/tenant.rb Outdated Show resolved Hide resolved
@alinvetian alinvetian merged commit b227064 into main Jan 24, 2025
5 checks passed
@alinvetian alinvetian deleted the account-cleanup branch January 24, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account management - reduce pencils
3 participants