Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"refactored Nathan's Private DBFS & added conditionals" #72

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

databeaks
Copy link
Contributor

I added a boolean variable in the azure/tf/modules/azure_spoke/variables.tf (default is true) for implementing private dbfs

Fortunately @nathanknox already had the private dbfs terraform code in the Azure SRA folder. I uncommented the azure/tf/modules/azure_spoke/dbfs_privatelink.tf file and added the following conditionals.
Each block in the azure/tf/modules/azure_spoke/dbfs_privatelink.tf will have:

count = var.boolean_create_private_dbfs ? 1 : 0
depends_on = [ azurerm_databricks_workspace.this ]

The first line checks if the variable boolean_create_private_dbfs is set to true (default) or false. Leaving as default or setting to explicit true in the *.tfvars will create all the private dbfs resources as long as the azurerm_databricks_workspace.this dependency is complete.

@nathanknox nathanknox merged commit ae202a9 into main Jun 18, 2024
1 check passed
@nathanknox
Copy link
Contributor

Looks good, thanks Tony!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants