"refactored Nathan's Private DBFS & added conditionals" #72
+108
−83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a boolean variable in the azure/tf/modules/azure_spoke/variables.tf (default is true) for implementing private dbfs
Fortunately @nathanknox already had the private dbfs terraform code in the Azure SRA folder. I uncommented the
azure/tf/modules/azure_spoke/dbfs_privatelink.tf
file and added the following conditionals.Each block in the azure/tf/modules/azure_spoke/dbfs_privatelink.tf will have:
The first line checks if the variable
boolean_create_private_dbfs
is set to true (default) or false. Leaving as default or setting to explicit true in the *.tfvars will create all the private dbfs resources as long as theazurerm_databricks_workspace.this
dependency is complete.