Implement strict set operations #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshRosen
reviewed
Nov 25, 2024
stephenamar-db
force-pushed
the
set
branch
2 times, most recently
from
2aa95a1 to
ac4167a
Compare
JoshRosen
reviewed
Dec 5, 2024
JoshRosen
reviewed
Dec 5, 2024
JoshRosen
reviewed
Dec 5, 2024
JoshRosen
reviewed
Dec 5, 2024
stephenamar-db
force-pushed
the
set
branch
2 times, most recently
from
f18b804 to
0c18d24
Compare
JoshRosen
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement strict operations, enabled by
--strict-set-operations.This PR also adds
--throw-error-for-invalid-sets, which should help find people not passing sets to the set methods.Finally, it fixes an inefficiency in std.member()