Allow 'any' examples in JSON schema #2289
Conversation
ilyakuz-db
requested review from
pietern,
andrewnester,
shreyas-goenka and
denik
as code owners
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -79,7 +79,7 @@ type Schema struct { | |||
|
|
|||
| // Examples of the value for properties in the schema. | |||
| // https://json-schema.org/understanding-json-schema/reference/annotations | |||
| Examples []any `json:"examples,omitempty"` | |||
| Examples any `json:"examples,omitempty"` | |||
There was a problem hiding this comment.
Also probably we could remove this field and add some custom field instead to use in docsgen. Currently it doesn't get any examples from doc and used only to keep this annotation example linked with particular json schema node
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
| @@ -122,7 +124,11 @@ func (p *openapiParser) extractAnnotations(typ reflect.Type, outputPath, overrid | |||
| if err != nil { | |||
| return err | |||
| } | |||
| err = yaml.Unmarshal(b, &overrides) | |||
| overridesDyn, err := yamlloader.LoadYAML(overridesPath, bytes.NewBuffer(b)) | |||
There was a problem hiding this comment.
Replaced marshaller with our custom loader because it was expecting "yaml" tags in structure while we use "json" everywhere
pietern
changed the title
| github.com/databricks/databricks-sdk-go/service/apps.AppResource: | ||
| "job": | ||
| github.com/databricks/databricks-sdk-go/service/apps.AppDeployment: | ||
| "create_time": |
There was a problem hiding this comment.
Why did the reordering happen?
There was a problem hiding this comment.
Seems that previously there lines were added manually but now it was auto-sorted after regenerating
Will keep an eye in it to see if there are any issues with ordering
| return "" | ||
| } | ||
| return examples[0].(string) | ||
| return examples[0] |
There was a problem hiding this comment.
This can call getExamples to avoid duplicate type casts.
|
The docs state that examples must be an array (ref). |
ilyakuz-db
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
anyexamples in json-schema type since we have many of them in open api specTests