Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dtype=None test for tables.values method #489

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add dtype=None test for tables.values method #489

merged 1 commit into from
Feb 11, 2021

Conversation

slim-builder
Copy link
Contributor

@slim-builder slim-builder commented Nov 8, 2020 •
edited
Loading

[ x ] Wrote test for feature

Changes proposed:
Add dtype=None test for tables.values method for #476

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 88.803% when pulling 882d75f on slim-builder:test_tables_val into 6bb01af on data-8:master.

adnanhemani
adnanhemani approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!!

@adnanhemani adnanhemani merged commit 834cf6e into data-8:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnanhemani adnanhemani adnanhemani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slim-builder @coveralls @adnanhemani