Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing to function util.plot_normal_cdf as asked in issue #476 #485

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Added testing to function util.plot_normal_cdf as asked in issue #476 #485

merged 3 commits into from
Feb 11, 2021

Conversation

athossampayo
Copy link
Contributor

@athossampayo athossampayo commented Oct 19, 2020

  • Wrote test for feature?
  • [ ] Added changes to CHANGELOG.md

Changes proposed:
Added tests to util.plot_normal_cdf as asked on issue #476
Did not add changes to CHANGELOG.md as did not see punctual tests documented there.`

Trying to be closer to the Open Source community, so please point any errors so I can improve!

@coveralls
Copy link

coveralls commented Oct 19, 2020

Coverage Status

Coverage increased (+1.02%) to 89.78% when pulling 2da73a6 on athossampayo:master into 6bb01af on data-8:master.

Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - loving how much this increased our test coverage! :D

@adnanhemani adnanhemani merged commit 2b825eb into data-8:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants