Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coinjoin): tx list performance #676

Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Dec 18, 2024

Issue being fixed or feature implemented

The transaction list on the home screen has performance issues.

What was done?

  • Do not call reloadTxDataSource too often, only once on launch and other special occasions
  • Only add/update the exact transaction that was changed
  • Consider transactions older than 30 minutes as valid and confirmed
  • Cache dashAmount and direction on DashSync side
  • Merge develop
  • Some CoinJoin fixes

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf December 18, 2024 07:33
@Syn-McJ Syn-McJ self-assigned this Dec 18, 2024
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 4878ac0 into dashpay:feat/coinjoin Dec 18, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the feat/coinjoin-tx-list-performance branch December 18, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants