Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the latest lints, require Dart 3.1 #719

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update to the latest lints, require Dart 3.1 #719

merged 2 commits into from
Nov 16, 2023

Conversation

kevmoo
Copy link
Member

@kevmoo kevmoo commented Nov 16, 2023

No description provided.

@kevmoo kevmoo requested a review from yanok November 16, 2023 17:53
@kevmoo kevmoo requested a review from natebosch November 16, 2023 18:05
yanok
yanok approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@yanok yanok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super sure, but I think we usually drop -wip in a separate commit. Please check with nbosch@

And if you end up bumping the version here, there is also something like version_test.dart that needs to be updated.

@copybara-service copybara-service bot merged commit 2f41028 into master Nov 16, 2023
7 checks passed
@copybara-service copybara-service bot deleted the latest_lints branch November 16, 2023 21:07
mosuem pushed a commit to dart-lang/test that referenced this pull request Oct 17, 2024
@copybara-github
Merge pull request dart-lang/mockito#719 from dart-lang:latest_lints
8b23521 
PiperOrigin-RevId: 583139202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanok yanok yanok approved these changes

@natebosch natebosch Awaiting requested review from natebosch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevmoo @yanok