MAINT: mpl join() deprecation #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* when using latest stable matplotlib our testsuite
produces hundreds of warnings like this:
```
tests/test_data_access_by_filesystem.py: 54 warnings
tests/test_summary.py: 99 warnings
/home/tyler/python_310_darshan_venv/lib/python3.10/site-packages/darshan/experimental/plots/data_access_by_filesystem.py:536:
MatplotlibDeprecationWarning: The join function was deprecated in
Matplotlib 3.6 and will be removed two minor releases later.
ax_filesystem_counts.get_shared_x_axes().join(ax_filesystem_counts,
list_count_axes[row - 1])
```
* this originates from this upstream PR:
matplotlib/matplotlib#21584
* turn this warning into an error in our CI, to prevent
further introductions of the deprecated functionality,
and fix it up where we already use it, based on the
directions in the PR above
shanedsnyder
approved these changes
Oct 13, 2022
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matplotlibour testsuite produces hundreds of warnings like this (example log from BUG: memleak part 3 (CFFI only) #819 :https://github.com/darshan-hpc/darshan/actions/runs/3137604371/jobs/5095963509) :this originates from this upstream PR: Move towards having get_shared_{x,y}_axes return immutable views. matplotlib/matplotlib#21584
turn this warning into an error in our CI, to prevent further introductions of the deprecated functionality, and fix it up where we already use it, based on the directions in the PR above