Add support for middleware. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update our routing tests to ensure the Trout-Pattern header is set as we expect.
It's gross and messy to have lots of middleware smushed into the Handler method calls, with lots of paren-nesting. Give the router and each endpoint-terminator (everywhere a Handler can be registered) the ability to register one or more middleware functions that will wrap that Handler. Router middleware will be called for every Handler, and called before Handler-specific middleware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper methods that will support middleware both at the endpoint level and at the router level. This allows us a cleaner interface for setting middleware on an endpoint (before it was just nested functions with lots of parens) and significantly cleans up endpoints when using, e.g., log injection middleware that you want present on every endpoint but you want injected after trout has set its request headers, so e.g. you can use them in the logs.