Fix crash after deleting style or preset that was selected in shortcuts dialog #18244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also works in lightroom/styles module and can be visually mapped there
|
Merged in master, first commit cherry-picked for 5.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18241 (both the crash, which could also happen when deleting presets, and the styles shortcut being removed when overwriting).
This also cherry-picks a commit from ancil that shows tooltips assigned to styles when hovering over them in the styles module and allows assigning shortcuts in visual mapping mode (or directly going to the style in shortcuts dialog by selecting mapping mode and clicking on the style in the module's list). @TurboGit you may find this too invasive for 5.0.1