Attempt to fix #18110. #18226
Merged
Attempt to fix #18110. #18226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ralfbrown proposed fix.
TurboGit
added
bugfix
|
No crash for me using this, but I got such a crash only once, so hard to reproduce on my side. |
|
Could never reproduce so far ... |
|
The crash is 100% reproducible on macOS and I can confirm that this PR fixes the problem. |
|
Great merging in master and 5.0.x branch then. |
|
Release note:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ralfbrown proposed fix.