Skip to content

Commit

Permalink
Relax splash on top
Browse files Browse the repository at this point in the history
While we possibly spend a lot of time (like in xmp crawler ...) while having the splash screen open
users might want to do other work but the splash requested to be "above" prohibits that.

So let us **not** interfere in WM/user actions.

If we don't enforce the splash via preferences we close it right after the the crawler has done it's noteworthy
work.
  • Loading branch information
jenshannoschwalm committed Jan 18, 2025
1 parent f5f3c09 commit 24af95e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions src/common/darktable.c
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,8 @@ int dt_init(int argc, char *argv[], const gboolean init_gui, const gboolean load
darktable_splash_screen_create(NULL, TRUE); // force the splash screen for the crawl even if user-disabled
// scan for cases where the database and xmp files have different timestamps
changed_xmp_files = dt_control_crawler_run();
if(!dt_conf_get_bool("show_splash_screen"))
darktable_splash_screen_destroy();
}
}

Expand Down
1 change: 0 additions & 1 deletion src/gui/splash.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,6 @@ void darktable_splash_screen_create(GtkWindow *parent_window,
gtk_window_set_decorated(GTK_WINDOW(splash_screen), FALSE);
gtk_widget_show_all(splash_screen);
gtk_widget_hide(GTK_WIDGET(remaining_box));
gtk_window_set_keep_above(GTK_WINDOW(splash_screen), TRUE);
_process_all_gui_events();
}

Expand Down

0 comments on commit 24af95e

Please sign in to comment.